Repository navigation
Conversation
libass use fonts that are attached to the mkv. Those attachments are missing when the stream is transcoded. Due to that, when the selected subtitle is ASS/SSA and the playback isn't direct play, download the source's font attachments from the server and pass them to the AssHandler. The font attachment detection is based on https://github.com/ietf-wg-cellar/matroska-specification/blob/1a943ead9bb4c67b02b966cebafe51c8c074e703/cellar-matroska/attachments.md?plain=1#L87-L111 + https://github.com/mpv-player/mpv/blob/a39482e7a580e64ea58ac0e1fc2838100b6320d3/sub/sd_ass.c#L144-L154 Fix: damontecres#1634
|
I tested this branch with the same setup I used to open #1634, and confirmed it is fixed! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
libass use fonts that are attached to the mkv.
Those attachments are missing when the stream is transcoded. Due to that, when the selected subtitle is ASS/SSA and the playback isn't direct play, download the source's font attachments from the server and pass them to the AssHandler.
The font attachment detection is based on https://github.com/ietf-wg-cellar/matroska-specification/blob/1a943ead9bb4c67b02b966cebafe51c8c074e703/cellar-matroska/attachments.md?plain=1#L87-L111 + https://github.com/mpv-player/mpv/blob/a39482e7a580e64ea58ac0e1fc2838100b6320d3/sub/sd_ass.c#L144-L154
Related issues
#1634
Testing
Emulator
Screenshots
Not relevant
AI or LLM usage
I used claude to find out how to download the fonts from the jellyfin server + do the font caching.
To test this PR, I used this file https://files.catbox.moe/q4eab5.mkv and played it (while been transcoded).
I verified that the fonts where indeed loaded properly.