Skip to content

Fix remembered subtitles not applied on next episode - #2229

Merged
damontecres merged 1 commit into
damontecres:mainfrom
RealFoxass:fix-next-episode-subtitles
Nov 15, 2026
Merged

damontecres merged 1 commit into
damontecres:mainfrom
RealFoxass:fix-next-episode-subtitles

Conversation

@RealFoxass

Copy link
Copy Markdown
Contributor

Description

Fixes the issue where Wholphin would save your subtitle choices, But when an episode is starting the player loads the saved audio choices instead so the saved subtitle track was never used so the app falls back to its default choice which favors externals or downloaded subtitles.

The same issue but in reverse in the StreamChoiceService had the same issue so the the audio track that was picked and saved could be ignored

Related issues

To reproduce you'll pick a subtitle and then when going to a new episode it will swap back to default choice

Testing

I tested this on TCL Google TV

Screenshots

N/A

AI or LLM usage

Used Claude found the two lines of code and wrote the change while I tested on my tv

@damontecres damontecres left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I did a bad job with copy-paste it seems, thanks for the fix!

bonfiglioalessio added a commit to bonfiglioalessio/Nigiro that referenced this pull request Nov 13, 2026
@damontecres
damontecres merged commit 889fae3 into damontecres:main Nov 15, 2026
2 checks passed
@alexkahler

Copy link
Copy Markdown

As someone who watches a lot of anime - this fix is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants