Repository navigation
Fix remembered subtitles not applied on next episode - #2229
Merged
damontecres merged 1 commit intoNov 15, 2026
Merged
Conversation
damontecres
approved these changes
Nov 12, 2026
damontecres
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution! I did a bad job with copy-paste it seems, thanks for the fix!
bonfiglioalessio
added a commit
to bonfiglioalessio/Nigiro
that referenced
this pull request
Nov 13, 2026
|
As someone who watches a lot of anime - this fix is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where Wholphin would save your subtitle choices, But when an episode is starting the player loads the saved audio choices instead so the saved subtitle track was never used so the app falls back to its default choice which favors externals or downloaded subtitles.
The same issue but in reverse in the StreamChoiceService had the same issue so the the audio track that was picked and saved could be ignored
Related issues
To reproduce you'll pick a subtitle and then when going to a new episode it will swap back to default choice
Testing
I tested this on TCL Google TV
Screenshots
N/A
AI or LLM usage
Used Claude found the two lines of code and wrote the change while I tested on my tv