Skip to content

Only report AV1 support for hardware decoders - #2200

Merged
damontecres merged 1 commit into
damontecres:mainfrom
swindlesmccoop:fix/av1-hardware-decoder-detection
Nov 15, 2026
Merged

damontecres merged 1 commit into
damontecres:mainfrom
swindlesmccoop:fix/av1-hardware-decoder-detection

Conversation

@swindlesmccoop

@swindlesmccoop swindlesmccoop commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Description

When AV1 software decoding is disabled, supportsAV1() checks the system generically for any AV1 decoder rather than discriminating only for hardware ones. In my case, LineageOS exposes a software AV1 decoder, which Wholphin then saw a decoder and used it rather than checking if it was actually a hardware decoder, despite software decoding being disabled. I changed it to check for hardware acceleration rather than trust that any listed decoder is a hardware one.

Related issues

Couldn't find any issues related to this bug. Steps to reproduce:

  1. Have a system without AV1 hardware decoding but AV1 software decoding in the operating system
  2. Disable the AV1 software decoding toggle in Settings
  3. Play back an AV1 video and watch it use the system's software decoder instead of transcoding

Testing

I manually tested on my Nvidia Shield TV Pro 2019 (mdarcy) on LineageOS. I played an AV1 video from my server with the AV1 software decoding toggle disabled and it started transcoding to HEVC.

Screenshots

N/A

AI or LLM usage

Most of this was created with Claude Opus 5.5. Everything was tested manually.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@damontecres damontecres left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It's interesting that they package it by default. Definitely makes sense to exclude it by default.

Wholphin also includes a dav1d decoder if users want to force software AV1 decoding on the device.

@damontecres damontecres added this to the v1.2.0 milestone Nov 12, 2026
bonfiglioalessio added a commit to bonfiglioalessio/Nigiro that referenced this pull request Nov 13, 2026
@damontecres
damontecres merged commit 7488502 into damontecres:main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants