Repository navigation
Only report AV1 support for hardware decoders - #2200
Merged
damontecres merged 1 commit intoNov 15, 2026
Merged
damontecres merged 1 commit into
damontecres merged 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
damontecres
approved these changes
Nov 12, 2026
damontecres
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution! It's interesting that they package it by default. Definitely makes sense to exclude it by default.
Wholphin also includes a dav1d decoder if users want to force software AV1 decoding on the device.
bonfiglioalessio
added a commit
to bonfiglioalessio/Nigiro
that referenced
this pull request
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
AV1 software decodingis disabled,supportsAV1()checks the system generically for any AV1 decoder rather than discriminating only for hardware ones. In my case, LineageOS exposes a software AV1 decoder, which Wholphin then saw a decoder and used it rather than checking if it was actually a hardware decoder, despite software decoding being disabled. I changed it to check for hardware acceleration rather than trust that any listed decoder is a hardware one.Related issues
Couldn't find any issues related to this bug. Steps to reproduce:
AV1 software decodingtoggle in SettingsTesting
I manually tested on my Nvidia Shield TV Pro 2019 (
mdarcy) on LineageOS. I played an AV1 video from my server with theAV1 software decodingtoggle disabled and it started transcoding to HEVC.Screenshots
N/A
AI or LLM usage
Most of this was created with Claude Opus 5.5. Everything was tested manually.