Repository navigation
Conversation
Adds a :baselineprofile module whose BaselineProfileGenerator signs in to a Jellyfin server (the public demo server by default, or one passed as instrumentation args) and walks home, the nav drawer, a library, details and playback with D-pad keys. The generated profile is committed under app/src/main/generated/baselineProfiles and a manual workflow regenerates it. Follow-up to damontecres#1984 for damontecres#553. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaQ3kKFs9rarp6Gp2rApSB
Compares cold start and navigation frame timings with no precompilation against the baseline profile installed. The sign-in and navigation helpers are shared with the profile generator. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaQ3kKFs9rarp6Gp2rApSB
Exclude androidx.** (those libraries ship their own profiles that AGP merges in) and j$.**, and drop the startup profile since the plugin does not filter it and it would put the AndroidX rules back. The baseline profile goes from 51.6k rules (5.8 MB) to 21.6k (2.4 MB) while keeping all of Wholphin's rules. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AaQ3kKFs9rarp6Gp2rApSB
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stage 2 of #553, following #1984 (which made the packaged profile actually get installed). This generates a baseline profile from Wholphin's own code instead of only the AndroidX library rules.
:baselineprofilemodule (com.android.test+androidx.baselineprofile1.5.0, works with AGP 9.2.1).BaselineProfileGeneratorsigns in and walks home, the nav drawer, a library, a details page and playback start, using only D-pad keys like a TV remote. It signs in to the public Jellyfin demo server by default; use another server with-Pandroid.testInstrumentationRunnerArguments.wholphin.server/username/password. Nothing is stored../gradlew :app:generateBaselineProfile.app/src/main/generated/baselineProfiles/(baseline-prof.txt, 21.6k rules, 2.4 MB).androidx.**andj$.**are excluded because AndroidX libraries already ship their own profiles that AGP merges in. There is no startup profile because the plugin doesn't filter it.Generate baseline profileworkflow regenerates it on a KVM runner and uploads it as an artifact to commit. It adds no new actions. I have not run it in CI.WholphinBenchmarks(Macrobenchmark) compares no precompilation against the profile installed.DEVELOPMENT.mddocuments regenerating and benchmarking.Does it help?
Honest answer from an API 34 AOSP x86_64 emulator, 10 iterations each (indicative only, a fast emulator hides most of the effect):
timeToInitialDisplaymedianStartup shows no measurable change on the emulator. Frame timings improve slightly, mostly in the tail. The target is slow devices (CCwGTV, Fire TV), which I have not tested; real-device numbers from the benchmark would be the proper check.
The release APK contains
assets/dexopt/baseline.prof(about 24 KB vs about 15 KB before).Related issues
#553
Testing
generateBaselineProfilesucceeded on the managed emulator (signs in to the demo server).assembleDefaultReleasesucceeds and packages the profile.AI or LLM usage
I used Claude Code for this: it wrote the module, generator, workflow and docs, and ran the emulator generation and benchmarks. I have reviewed the changes and can explain them.
🤖 Generated with Claude Code