Skip to content

Give the played-percent bar a track and the watched badge colour - #2089

Open
SergeiAK wants to merge 3 commits into
damontecres:mainfrom
SergeiAK:progress-bar-track
Open

SergeiAK wants to merge 3 commits into
damontecres:mainfrom
SergeiAK:progress-bar-track

Conversation

@SergeiAK

@SergeiAK SergeiAK commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

The watch-progress bar on cards disappears over light artwork, and even where it is visible its length can't be read. Details and before/after screenshots are in #1989.

Two commits:

  1. Track. The fill now sits in a black track inset from the card edges, which also works as its outline, so the bar stays visible over any artwork and the empty remainder shows where 100% is. ItemCardImage and BannerCard drew the same bar with copied geometry; both now use one PlayedPercentBar composable.
  2. Colour. The fill uses the watched badge colour (WatchedIconBackground()), so the two marks on a card agree and follow the theme. Exceptions where the badge colour is too dark on the black track: Brown uses primary, Bold Blue and OLED Black keep tertiary. Contrast numbers per theme are in this comment.

The commits are separate on purpose: if you prefer the track alone with tertiary, as in the original issue, drop the second one.

Related issues

Closes #1989

Testing

  • Track: before/after screenshots in Watch-progress bar on cards has no track: invisible over light artwork, and its length can't be read #1989 were taken on an NVIDIA Shield TV Pro 2019 (Android 11), same library and theme, only the build differs.
  • Colour: all themes checked in ThemePreview in Android Studio (screenshot in the comment linked above).
  • The track has been in my fork's builds since September 20, the colour since October 11.
  • Rebased onto current main for this PR; ktlint 1.8.0 passes, :app:compileDefaultDebugKotlin passes.

Screenshots

Before and after on the Shield, OLED Black theme (the second commit keeps tertiary there, so this is exactly what the PR draws):

Before

progress-before-zoom

After

progress-after-zoom

All themes in ThemePreview, before and after:

themepreview-cards-before-after

More context in #1989 and the comment linked above.

AI or LLM usage

The problem, the design (track, inset, which colour per theme) and the screenshots are mine. The code was written with Claude (Claude Code): the shared PlayedPercentBar composable and the colour function. I reviewed every line and can explain it. This description was written by me in Russian and translated into English with the same assistant.

🤖 Generated with Claude Code

SergeiAK and others added 2 commits October 16, 2026 19:14
The bar is drawn straight onto the poster with nothing behind it, so on
busy or light artwork it disappears: there is no way to tell "half
watched" from "not started" at a glance, in any theme.

It now sits in a black track inset from the card edges, which doubles as
its outline, and the fill is thinner. Both cards that draw it share one
PlayedPercentBar composable rather than repeating the geometry.
The fill used tertiary, which in Orange, Red and Brown is a different hue
from the rest of the theme and from the watched badge on the same card.
Use the badge colour, except in Brown (badge too dark on the black track:
use primary) and Bold Blue / OLED Black (keep tertiary, it already matches).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user interface Related to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Watch-progress bar on cards has no track: invisible over light artwork, and its length can't be read

2 participants