Repository navigation
Conversation
The bar is drawn straight onto the poster with nothing behind it, so on busy or light artwork it disappears: there is no way to tell "half watched" from "not started" at a glance, in any theme. It now sits in a black track inset from the card edges, which doubles as its outline, and the fill is thinner. Both cards that draw it share one PlayedPercentBar composable rather than repeating the geometry.
The fill used tertiary, which in Orange, Red and Brown is a different hue from the rest of the theme and from the watched badge on the same card. Use the badge colour, except in Brown (badge too dark on the black track: use primary) and Bold Blue / OLED Black (keep tertiary, it already matches). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The watch-progress bar on cards disappears over light artwork, and even where it is visible its length can't be read. Details and before/after screenshots are in #1989.
Two commits:
ItemCardImageandBannerCarddrew the same bar with copied geometry; both now use onePlayedPercentBarcomposable.WatchedIconBackground()), so the two marks on a card agree and follow the theme. Exceptions where the badge colour is too dark on the black track: Brown usesprimary, Bold Blue and OLED Black keeptertiary. Contrast numbers per theme are in this comment.The commits are separate on purpose: if you prefer the track alone with
tertiary, as in the original issue, drop the second one.Related issues
Closes #1989
Testing
ThemePreviewin Android Studio (screenshot in the comment linked above).mainfor this PR;ktlint1.8.0 passes,:app:compileDefaultDebugKotlinpasses.Screenshots
Before and after on the Shield, OLED Black theme (the second commit keeps
tertiarythere, so this is exactly what the PR draws):Before
After
All themes in
ThemePreview, before and after:More context in #1989 and the comment linked above.
AI or LLM usage
The problem, the design (track, inset, which colour per theme) and the screenshots are mine. The code was written with Claude (Claude Code): the shared
PlayedPercentBarcomposable and the colour function. I reviewed every line and can explain it. This description was written by me in Russian and translated into English with the same assistant.🤖 Generated with Claude Code