Skip to content

Fix navigation drawer library names losing their suffix - #2071

Closed
javigmsuperka wants to merge 1 commit into
damontecres:mainfrom
javigmsuperka:fix/navigation-library-labels
Closed

javigmsuperka wants to merge 1 commit into
damontecres:mainfrom
javigmsuperka:fix/navigation-library-labels

Conversation

@javigmsuperka

Copy link
Copy Markdown

Instalado wholphin contra un servidor Jelly 12.1, Tengo varias carpetas con nombre y un espacio en mayusculas como por ejemplo PELICULAS INFANTILES , pero nvidia shield y varios google tv solo muestran la primera palabra que es PELICULAS. Con Codex hemos buscado el posible fallo, compilado nueva apk y testeado en shield y todo ha funcionad correctamente

Disable wrapping and use ellipsis for single-line navigation labels.
Widen expanded drawer items from 224dp to 300dp to leave room for
distinguishing library-name suffixes. Collapsed width is unchanged.

The combined change was verified by the reporter using a v1.0.8-based
test APK on an NVIDIA Shield. Neither change was tested independently.
The current-main build passes assembleDefaultDebug, all 385 tests in
testDefaultDebugUnitTest, and pre-commit checks on the changed files.

References #2069.
Implementation and technical investigation assisted by OpenAI Codex.
@javigmsuperka

Copy link
Copy Markdown
Author

Technical validation note (prepared with AI assistance):

  • Related report: [BUG] Navigation drawer drops library-name suffixes without ellipsis (1.0.8, NVIDIA Shield) #2069.
  • The patch changes only NavDrawer.kt and NavigationDrawerAndroid.kt: softWrap = false, overflow = TextOverflow.Ellipsis, and expanded drawer width 224.dp → 300.dp.
  • assembleDefaultDebug testDefaultDebugUnitTest --no-daemon: BUILD SUCCESSFUL, 385 tests across 48 suites, zero failures/errors/skips.
  • The repository's pre-commit hooks passed on both changed files, including KTLint.
  • The reporter confirmed the combined UI changes on their NVIDIA Shield using a v1.0.8-based custom test APK. The APK built from current main has not separately been installed on that device. No independent Google TV test of this patch is claimed.
  • Both UI changes were tested together; the sufficiency of either change alone remains unknown. The proposed word-wrap explanation has not been confirmed through on-device text-layout instrumentation.
  • Local builds used the documented optional MPV stub and omitted optional native FFmpeg/AV1 decoder extensions. This patch does not modify playback, dependencies, application identity, or build settings.

The PR description is the reporter's own text, reproduced verbatim without AI rewriting or translation. The source investigation, implementation and this technical note were prepared with OpenAI Codex assistance.

@damontecres

Copy link
Copy Markdown
Owner

Thanks for the contribution, but I don't want to change the open drawer width, so a better solution is use a marquee. I've done this in #2072

Also, please make sure to use the PR template when creating a PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants