Repository navigation
Conversation
…oding Fail instead of transcoding when retries don't fix a non-format error Only transcode the stream that failed when falling back from direct play Add tests for playback error handling
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My server that hosts Jellyfin stops the hard drives when no activity is detected.
So when I first launch a playback it's often time out.
And in this case the current code retry with allow allowAudioStreamCopy to true.
This cause another issue where the client receive the format : TS HEVC MP3 which result in no sound.
So I reworked the retry logic to do the following things :
Related issues
Not sure if it also caused by a timeout but the issue #879 has the same TS HEVC MP3 behavior.
Testing
Added unit tests
Screenshots
AI or LLM usage
Claude Opus 5.5 used to generate the test code