Repository navigation
Add support for server plugin - #1384
Conversation
|
I have implemented automatic Seerr Login via your jellyfin plugin in the following two PRs:
Next I will try to implement a generic CustomEndpoint row type in the Wholphin home layout, similar to how Streamyfin handles it. The idea: a row config carrying an arbitrary URL (plus optional headers/query params), which Wholphin GETs and renders as a list of BaseItemDtos. That way third-party plugins like jellyfin-plugin-home-sections can contribute rows to Wholphin's home screen by exposing a custom endpoint (for example |
Please try to keep it as simple and isolated as possible! |
|
I have implemented CustomEndpoints with the following two PRs: |
|
I have also implemented the feature to add additional pages to the nav drawer via the plugin. The changes in the client are actually quite a bit more extensive than in the other two:
In my opinion, with these three additional features, we would have covered all the key points for an initial release. After that, we can enhance the plugin’s user interface and perhaps push default settings to the client. But as I said, I would consider that a step for later. |
|
@matschi95 Sorry I haven't reviewed your PRs yet! I'm working to get a release out probably this week. After that will go back to the plugin work again. |
Adds a new HomeRowConfig variant `CustomEndpoint` that resolves rows by GET-ing an arbitrary Jellyfin endpoint returning QueryResult<BaseItemDto>. Lets third-party plugins (e.g. jellyfin-plugin-home-sections) feed rows into Wholphin without Wholphin needing specific knowledge of them. - Resolves both relative and absolute endpoint URLs via HttpUrl.resolve() - Auto-injects current userId as query param (overridable per-config) - Headers/Query are List<KeyValueEntry> to match the server-side plugin's XML-serializable shape - Auth token added automatically via AuthOkHttpClient
## Description This PR adds support for the CustomEndpoint implemented in damontecres/jellyfin-plugin-wholphin#4. With this it is now possible to use sections provided by [jellyfin-plugin-home-sections](https://github.com/IAmParadox27/jellyfin-plugin-home-sections) directly in the Wholphin client (fe. `My Request` or `Latest Movies`). Some endpoints need the userId for providing user-specific lists (fe. `My Requests`). Therefore the userId will always be added when calling a custom endpoint, because we can only define static items in our YAML definition. ### Related issues - Discussion about plugin integration: #598 - Pull request for Wholphin plugin integration: #1384 - **Changes needed** from our Plugin: damontecres/jellyfin-plugin-wholphin#4 ### Testing The feature was tested on an Android TV emulator. For the final test I have also implemented Wholphin support in the Home-Section-Plugin on my branch [develop/wholphin-plugin](https://github.com/matschi95/jellyfin-plugin-home-sections/tree/develop/wholphin-plugin). With this change, I was able to push all sections provided by their plugin to our Wholphin client without writing one single line to our Wholphin Plugin Configuration YAML. ## Screenshots No changes ## AI or LLM usage This PR was developed in pair with Claude (Anthropic). I understand the code and can explain every change made in the PR. Manual end-to-end testing was performed by me on an Android TV emulator.
Description
PR to add support for a Wholphin server plugin: https://github.com/damontecres/jellyfin-plugin-wholphin
Note: The plugin is not required to use Wholphin. It adds features the server admin can use to set default settings like the home page or eventually Seerr connection info.
Changes
Wholphin will use the home page settings in order of:
jellyfin-plugin-wholphinUnder customize home page, you can now see the "source" of the home settings. This also allows to pick a different source
Finally, instead of the home customization being saved in the background only locally, if there are any changes, a dialog is shown with options to save locally, server-side user profile, or discard.
So overall, it's more clear where the home page settings are from and where the user wants to save them.
Install
See instructions here
Related issues
Related to #598
Testing
WIP
Screenshots
N/A
AI or LLM usage
None