clamp to the edge#79
Conversation
|
@Fil Sorry, is this PR abandoned or is it still awaiting review? |
|
Yes, please review 🙏 |
I don't believe I have the power, @mbostock please could this get blessed with a review 🙏? |
|
You don’t need any special power to test this PR against real life use
cases, read the code and try to find conditions that will make it break ,
etc. :)
|
|
@Fil I personally can't spot any issues but I wouldn't exactly call myself an expert on this. I'm using this for a work process and we can't use node/npm or any alternative (self-hosting the d3 UMD .js file in vanilla JS), so I can't build it myself either to test 😆 . |
|
@mbostock is there any chance you could please take a look/review this change? It's been outstanding for ~5 months. |
|
@Fil what's the plan here 😆 it would be really amazing if we could get this change in, do you know anyone who can review? |
|
I have been using this, as a patch, for some days and it seems to work well on our data (small and medium size) |
3 participants
To avoid cutting the corners (#72), expand the data on the edges by 1 pixel (with the addition of a bit of blurring); then contract the shape back to the frame. Note that we must contract after smoothing.
closes #72