Skip to content

Rename configuration option blacklistHosts to blocklistHosts#2861

Merged
jennifer-shehane merged 12 commits into
cypress-io:5.0.0-releasefrom
laiscoolblue:rename-blacklisthosts
Jul 13, 2020
Merged

Rename configuration option blacklistHosts to blocklistHosts#2861
jennifer-shehane merged 12 commits into
cypress-io:5.0.0-releasefrom
laiscoolblue:rename-blacklisthosts

Conversation

@laiscoolblue

@laiscoolblue laiscoolblue commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

@CLAassistant

CLAassistant commented Jun 8, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane
jennifer-shehane self-requested a review June 9, 2020 03:35
@jennifer-shehane
jennifer-shehane marked this pull request as draft June 9, 2020 03:35

@jennifer-shehane jennifer-shehane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are referencing the incorrect key. Should be blacklistHosts, not blacklisthosts

Comment thread cypress.json Outdated
Comment thread source/faq/questions/using-cypress-faq.md Outdated
Comment thread source/guides/references/configuration.md Outdated
Comment thread source/guides/references/configuration.md Outdated
laiscoolblue and others added 4 commits June 15, 2020 12:08
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@jennifer-shehane
jennifer-shehane self-requested a review June 15, 2020 10:12
@jennifer-shehane
jennifer-shehane changed the base branch from develop to 5.0.0-release June 23, 2020 05:58
@jennifer-shehane jennifer-shehane mentioned this pull request Jun 24, 2020
14 tasks
@jennifer-shehane
jennifer-shehane marked this pull request as ready for review July 13, 2020 08:46
@jennifer-shehane
jennifer-shehane merged commit b6a77ea into cypress-io:5.0.0-release Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants