Skip to content

Add Logitech feature Illumination - #30

Open
abergmeier wants to merge 1 commit into
cvuchener:masterfrom
abergmeier:logitech_lights
Open

Add Logitech feature Illumination#30
abergmeier wants to merge 1 commit into
cvuchener:masterfrom
abergmeier:logitech_lights

Conversation

@abergmeier

Copy link
Copy Markdown

This makes it more concrete on Litra Glow.
Also mention that we saw 0x1eb0 on Litra Glow.

This makes it more concrete on Litra Glow.
Also mention that we saw 0x1eb0 on Litra Glow.
{ 0x1bc0, "Persistent remappable action" },
{ 0x1d4b, "Wireless device status" },
{ 0x1e00, "Enable hidden features" },
//{ 0x1eb0, "Seen on Logitech Litra Glow" },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1EB0 is also used in a number of other devices, like a mouse from 2015, another mouse, etc.
Short of knowing what it is, I don't see a reason to add it to the list.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an internal generic test/development feature that's not useful to users and won't be publicly documented. Devices do different things with that feature and it's not specific to the Litra Glow.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the documentation, that it IS a test feature a good reason to add it to the list - even only as a comment?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that depends on the purpose of the list. It seems it mostly lists features that showed up in public documentation. But one could obviously shoot for completeness, in which case { 0x1eb0, "Internal test feature" } would be an entirely reasonable entry. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants