Fix #671: restrict Cucumber property pages to IResource selections - #699
Open
alef75 wants to merge 1 commit into
Open
Fix #671: restrict Cucumber property pages to IResource selections#699alef75 wants to merge 1 commit into
alef75 wants to merge 1 commit into
Conversation
…tions The Cucumber and Java Backend property pages were contributed to org.eclipse.ui.propertyPages with no objectClass/adaptable/enabledWhen filter, so they were offered for any selection. When rendered against a non-IResource element (e.g. a Remote System Explorer connection), getNode() dereferenced a null resource and threw a NullPointerException, breaking the whole Properties dialog. - Add <enabledWhen><adapt type=IResource/></enabledWhen> to both property page contributions, so they are only offered for IResource-adaptable selections. - Make CucumberEditorProperties#getNode and CucumberJavaBackendProperties#getNode null-safe against both a null resource AND a resource with no project (the workspace root passes the IResource filter but IWorkspaceRoot#getProject() returns null, which ProjectScope otherwise rejects with an IllegalArgumentException), and guard every call site (createContents/performOk/performDefaults) that dereferences the result. getElement().getAdapter(IResource.class) can still return null for an element the adapter manager otherwise treats as adaptable, so the enablement filter alone does not fully close the NPE; the affected pages now show a not-applicable message instead of crashing. - Align performOk()'s guard in both property pages to the control field already used by performDefaults()/createContents(), rather than recomputing getNode(), so the two stay consistent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cucumber and Java Backend property pages were contributed to org.eclipse.ui.propertyPages with no objectClass/adaptable/enabledWhen filter, so they were offered for any selection. When rendered against a non-IResource element (e.g. a Remote System Explorer connection), getNode() dereferenced a null resource and threw a NullPointerException, breaking the whole Properties dialog.