Skip to content

fix(HillasIntersection): use geometry frame focal length for CameraFrame reconstruction #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
STSpencer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(HillasIntersection): use geometry frame focal length for CameraFrame reconstruction #3054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9a97a0
fix(HillasIntersection): use geometry frame focal length instead of e…
STSpencer Jul 9, 2026
63e2e31
Rename bugfix file to 3054.bugfix.rst
STSpencer Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/changes/3054.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Fix ``HillasIntersection`` using the ``equivalent_focal_length`` instead of the
Comment thread
maxnoe marked this conversation as resolved.
focal length the camera geometry (and thus the Hillas parametrization) was
defined with, when reconstructing from ``CameraHillasParametersContainer``.
Using the equivalent instead of the (by default) effective focal length
introduced a plate-scale error that grows with the distance of the image from
the camera center, degrading the angular reconstruction for off-axis and
high-energy showers. ``HillasIntersection`` now uses
``camera.geometry.frame.focal_length``, consistent with ``HillasReconstructor``.
4 changes: 3 additions & 1 deletion src/ctapipe/reco/hillas_intersection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ def _predict(self, hillas_dict, array_pointing, telescopes_pointings=None):

for tel_id, hillas in hillas_dict.items():
if isinstance(hillas, CameraHillasParametersContainer):
focal_length = self.subarray.tel[tel_id].optics.equivalent_focal_length
focal_length = self.subarray.tel[
tel_id
].camera.geometry.frame.focal_length
camera_frame = CameraFrame(
telescope_pointing=telescopes_pointings[tel_id],
focal_length=focal_length,
Expand Down
Loading