-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add branch pipeline infra #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
creova-gif
wants to merge
5
commits into
main
Choose a base branch
from
chore/add-pipeline-infra
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+213
−17
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5b481c0
chore: add PR template
creova-gif 13ea6bf
chore: add local git pipeline setup script
creova-gif 0b36273
ci: add PR validation pipeline (build-only)
creova-gif 823a347
fix: update CI workflow to use pnpm
Justin-Mafie c5c1685
chore: update pnpm-lock.yaml
Justin-Mafie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # 📝 Pull Request Template | ||
|
|
||
| ## Description | ||
| <!-- Provide a clear, concise summary of the changes, the problem being solved, and how this fits into our system. --> | ||
|
|
||
| --- | ||
|
|
||
| ## 🚀 Type of Change | ||
| - [ ] 🐛 Bug Fix | ||
| - [ ] ✨ New Feature | ||
| - [ ] 🔒 Security / Vulnerability Patch | ||
| - [ ] 💄 Redesign / Polish / Brand Alignment | ||
| - [ ] 🧹 Chore / Environment Scaffold | ||
|
|
||
| --- | ||
|
|
||
| ## 🛡️ CREOVA Quality Assurance Checklist | ||
| *Before requesting a review or merging, verify all applicable checks are completed. Branch, PR, and merge every single time — even for solo fixes.* | ||
|
|
||
| ### 1. Integrity & Real-World Truth (Anti-Fabrication Standards) | ||
| *We enforce a strict policy against misleading mock states, fake labels, or unpersisted UI changes.* | ||
| - [ ] **No "Live"/"Active" claims on static or simulated features:** any status label implying a real-time or fully-wired system is only used when that system is actually live. | ||
| - [ ] **Real backend persistence:** user-facing "Save" actions actually persist to the database, not just local/session state. | ||
| - [ ] **Actual pipelines (no fakes):** AI/voice/processing features use real backend pipelines rather than simulated or hardcoded frontends. | ||
| - [ ] **Transparent demo-mode labels:** any feature running on sample/seed data is honestly labeled as such — no fabricated "live" framing. | ||
| - [ ] **Authorized admin access:** sensitive consoles and developer views have RBAC gates and are removed from general user navigation. | ||
|
|
||
| ### 2. Security & Database Integrity | ||
| - [ ] **Supabase JWT & Edge Functions:** edge-function authorization has been validated (`verify_jwt = true` enforced unless explicitly audited for public use). | ||
| - [ ] **Row-Level Security (RLS):** all new or modified Supabase tables have active RLS policies, especially for financial or personal data. | ||
| - [ ] **Migrations actually applied:** any new migration file has been run against the target environment, not just committed to git. | ||
| - [ ] **Clean upgrade/payment paths:** payment screens and upgrade options are fully validated; paid tiers cannot be granted for free. | ||
|
|
||
| ### 3. Performance, Layout & Localization | ||
| - [ ] **Robust offline handling (where applicable):** features preserve offline-created or offline-completed actions and do not silently discard them. | ||
| - [ ] **Copy & truncation quality:** UI strings are checked for localization accuracy and don't truncate awkwardly on small displays. | ||
| - [ ] **Visual constraints:** charts, SVGs, and layout components handle negative/zero-width constraints without rendering crashes. | ||
|
|
||
| --- | ||
|
|
||
| ## 🎯 Target Branch | ||
| - [ ] **`dev`** (Active Development: where all features integrate first) | ||
| - [ ] **`staging`** (Dress Rehearsal: mirrors production to catch issues before launch) | ||
| - [ ] **`main`** (Sacred Production Branch: protected, user-facing live environment) | ||
|
|
||
| --- | ||
|
|
||
| ## 🧪 Testing & Verification | ||
| <!-- Describe the tests run to verify these changes. Provide steps to reproduce the verification. --> | ||
|
|
||
| --- | ||
|
|
||
| ## 📸 Screenshots / Recordings | ||
| <!-- If modifying UI or layout, attach visual proof here. --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: CI/CD Branching Pipeline | ||
|
|
||
| on: | ||
| push: | ||
| branches: [dev, staging, main] | ||
| pull_request: | ||
| branches: [dev, staging, main] | ||
|
|
||
| jobs: | ||
| validate: | ||
| name: Validate Code Changes | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v2 | ||
| with: | ||
| version: 8 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'pnpm' | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm run build | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: creova-gif/SEEN
Length of output: 1063
🌐 Web query:
pnpm lockfileVersion 9.0 pnpm 8 frozen-lockfile compatibility💡 Result:
pnpm 8 and lockfile version 9.0 are not compatible [1]. Lockfile version 9.0 was introduced in pnpm v9.0.0 [2][3]. pnpm 8 does not support, read, or parse lockfile version 9.0 [1]. If you attempt to run pnpm install or pnpm install --frozen-lockfile with pnpm 8 on a project using lockfile version 9.0, the command will fail, typically with an error indicating that the lockfile version is incompatible or that no compatible lockfile was found [4][1]. Because pnpm 8 cannot process version 9.0 lockfiles, you must upgrade your project to use pnpm 9 or newer to work with that lockfile format [1]. Conversely, if you need to maintain compatibility with a pnpm 8 environment, the lockfile must be generated or downgraded to a version supported by pnpm 8, specifically lockfile version 6.0 [5][2].
Citations:
Use pnpm 9 or newer.
pnpm-lock.yamluses lockfile format9.0, which pnpm 8 cannot process.pnpm install --frozen-lockfilecan therefore fail before the build.🧰 Tools
🪛 zizmor (1.29.0)
[warning] 10-24: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
🤖 Prompt for AI Agents