Skip to content

chore: Completely remove executedFeeAmount from API #3232

Description

@sunce86

Background

Once all executed fees are in the same token (surplus token), we can show following in the API:

  1. executedFee = executedFee + executedFeeAmount
  2. executedFeeAmount = 0 for ALL orders

as there are no clients that are interested in executedFeeAmount solely, and also, this field is only kept for legacy orders.

This effectively means we can remove executedFeeAmount from API.

Acceptance criteria

There is only ONE fee in the API that represents the total fee that was taken for execution of an order, and it's called executedFee.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedThis issue is blocked by some other work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions