Skip to content

chore: Drop support for market orders in solvers crate #2611

Description

@sunce86

Background

Dependent on #2543

Remove class::Market order class variant and remove Fee::Protocol variant from the solvers crate domain.

Details

Since we dropped the support for legacy market orders, once we make sure

  1. All solvers are moved to use solvers api directly (dropped support for "legacy" solvers)
  2. All solvers use limit orders for quotes

we can safely remove class::Market type of orders since those are not used anymore. Also, handling the fee could be simplified by removing the Fee::Protocol variant.

This task does not capture making these changes to the solvers API. This can be a separate PR since API changes should be kept plain and simple so we can revert them if needed.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions