BlobLTTIntegrator extended with added support for expanding blob radius - #203
BlobLTTIntegrator extended with added support for expanding blob radius#203grzegorzbor wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 97.18% 97.19% +0.01%
==========================================
Files 52 52
Lines 5045 5071 +26
==========================================
+ Hits 4903 4929 +26
Misses 142 142 ☔ View full report in Codecov by Harness. |
7e4e2bb to
4c487f4
Compare
| ] | ||
| assert u.allclose(u.Quantity(widths), 2 * (1e16 * u.cm / c).to("s"), rtol=1e-12) | ||
|
|
||
| def test_expanding_window_has_asymmetric_limits(self): |
There was a problem hiding this comment.
as we discussed today this test is very weak (it only checks sign) instead it is much better to include a test in which min and max times are calculated by hand and compared with the output
| or, converting to the integration over dτ: | ||
|
|
||
| The integration limits are such that tau spans [-R/c, +R/c]. | ||
| F(nu, t_bc) = ∫ W(τ) * F_std(nu, t_bc + τ) dτ |
There was a problem hiding this comment.
dxi is not equal dtau, so W(xi) and W(tau) cannot be the same 'W' (there is a factor 'c' of difference.
| Writing: ``β_exp = v_exp/c``,``R_t = R(t_bc)`` and ``ρ = cτ/R_t`` (ρ is a line-of-sight depth measured in units of the R_t), | ||
| we obtain: | ||
|
|
||
| R(t_bc+τ) = R_t + v_exp·τ = R_t + β_exp·c·τ = R_t(1 + β_exp·ρ) |
There was a problem hiding this comment.
it is still the same formula as L45 just with beta instead of v. You could immediately introduce beta in L45 and avoid L50
2 participants
No description provided.