feat: close/delete review actions and layout fixes [] - #11143
Merged
david-shibley-contentful merged 4 commits intoJul 29, 2026
Merged
feat: close/delete review actions and layout fixes []#11143david-shibley-contentful merged 4 commits into
david-shibley-contentful merged 4 commits into
Conversation
…nu on review page Close navigates back to the jobs list without terminating the run, so users can return to it later via the Review button. Delete (in the ... menu) triggers the existing confirm flow that cancels the run on the backend. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
david-shibley-contentful
changed the title
… and update stale test strings Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Franco Banfi (FBanfi)
left a comment
Franco Banfi (FBanfi)
left a comment
Collaborator
There was a problem hiding this comment.
Looks clean!! Left two small comments!
| {!hasCreatedEntries && ( | ||
| <Menu> | ||
| <Menu.Trigger> | ||
| <button type="button" className={moreActionsButton} aria-label="More actions"> |
Collaborator
There was a problem hiding this comment.
Can we use Forma 36 components here instead of raw html elements?
Collaborator
There was a problem hiding this comment.
Even though this is a small UI change, it would be nice to include a screenshot or video showing how it looks. That way, we can make sure it's working correctly and that the change makes sense from a UX perspective.
…button in legacy flow RunsPage was missing margin: auto so content pinned left. MainPageView had OAuthConnector in its own column item; wrap heading + connector in a space-between Flex row so the button aligns to the right. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
david-shibley-contentful
changed the title
…36 components Swap the ⋯ raw <button> for IconButton and the mode-toggle raw <button>s for Button with startIcon, as suggested in PR review. Removes the now- unused moreActionsButton style from ReviewPage.styles.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Franco Banfi (FBanfi)
approved these changes
Jul 29, 2026
Franco Banfi (FBanfi)
left a comment
Franco Banfi (FBanfi)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! 💯
david-shibley-contentful
changed the title
david-shibley-contentful
deleted the
feat/drive-integration-close-and-delete-review
branch
July 29, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Generated with Claude Code