Conversation
ssanthosh
requested review from
gpeacock,
mpgopala,
ok-nick,
scouten-adobe and
tmathern
September 28, 2026 18:22
Merging this PR will not alter performance
Comparing Footnotes
|
tmathern
reviewed
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Does this change matches the spec and spirit of the spec from https://spec.c2pa.org/specifications/specifications/2.4/specs/C2PA_Specification.html#ocsp_online (towards the bottom of the section, just above 15.10)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Fixes #2644
Changes are similar to #2664
Problem
An OCSP response with
certStatus = goodwhose validity window ([thisUpdate, nextUpdate]) does not cover the reference instant was misclassified assigningCredential.ocsp.revoked. Becausecheck_ocsp_statusturns that status intoCertificateTrustError::CertificateNotTrusted, a certificate the responder explicitly said was not revoked was treated as untrusted. A clock skew of a single second between the responder and the validator was enough to flip a freshgoodinto a false revocation.Fix
In the
CertStatus::Goodbranch ofOcspResponse::from_der_checked, an out-of-window response now logssigningCredential.ocsp.unknown(informational) instead ofsigningCredential.ocsp.revoked(failure). "Good outside the window" is an inconclusive outcome, not a revocation, so certificate trust is no longer failed on it.Tests added
Updated the
validityunit test (which previously asserted the buggyREVOKEDbehavior) to assert an out-of-windowgoodresponse now yieldssigningCredential.ocsp.unknown, produces no validation error, and is logged as informational.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.