Skip to content

build: enable use of this project as a CMake subproject - #105

Merged
dyro merged 1 commit into
contentauth:mainfrom
kostiantynperehuda:enable-cmake-addsubdirectory-pr
Nov 4, 2025
Merged

dyro merged 1 commit into
contentauth:mainfrom
kostiantynperehuda:enable-cmake-addsubdirectory-pr

Conversation

@kostiantynperehuda

Copy link
Copy Markdown
Contributor

This change allows the project to be included as a subdirectory in another CMake project using add_subdirectory()

@yogeshbdeshpande

Copy link
Copy Markdown

Please note that the ADOBE CLA was signed from Arm as an organisation so this contribution needs to proceed now.

Also, request add suitable reviewer to the PR and please provide review comments and approve.

Thanks for all help.

If any questions: Please contact Yogesh.Deshpande@arm.com

@yogeshbdeshpande

Copy link
Copy Markdown

@gpeacock : Please add suitable reviewers

@scouten-adobe scouten-adobe self-assigned this Nov 3, 2025
@scouten-adobe

Copy link
Copy Markdown
Contributor

@yogeshbdeshpande I'm tracking down why the CLA bot isn't recognizing your signature.

@scouten-adobe

Copy link
Copy Markdown
Contributor

@yogeshbdeshpande I think this might be an issue if you signed the CLA instead of @kostiantynperehuda.

@gpeacock
gpeacock requested a review from tmathern November 3, 2025 21:06
@gpeacock
gpeacock requested a review from dyro November 3, 2025 21:07
@gpeacock

gpeacock commented Nov 3, 2025

Copy link
Copy Markdown
Member

I'm ok with this change, I just want to make sure that it doesn't impact existing projects that depend on this. @dyro @tmathern

@yogeshbdeshpande

Copy link
Copy Markdown

@yogeshbdeshpande I think this might be an issue if you signed the CLA instead of @kostiantynperehuda.
I signed the CLA on behalf of my organisation, which is Arm.

So we believe any Arm individual should be able to submit the same!

@scouten-adobe

Copy link
Copy Markdown
Contributor

@yogeshbdeshpande I think this might be an issue if you signed the CLA instead of @kostiantynperehuda.
I signed the CLA on behalf of my organisation, which is Arm.

So we believe any Arm individual should be able to submit the same!

In principle, I'd agree with you, but I don't think our bot is smart enough to identify the relevant company. In any case, I'll merge once @dyro and @tmathern have reviewed. This may take another day or two there is a one-day PTO involved for one of them.

@dyro dyro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyro

dyro commented Nov 4, 2025 •

Copy link
Copy Markdown
Contributor

Merging with two failures:

  1. CLA issues, which is discussed above.
  2. "Build and publish docs" is failing because this is on a fork. Will try to re-run this job manually when the changes make it to main.

@dyro
dyro merged commit 3278d84 into contentauth:main Nov 4, 2025
4 of 6 checks passed
@yogeshbdeshpande

Copy link
Copy Markdown

Thank you @gpeacock and @dyro for your timely help

May I request please also review PR #104 and provide your valuable guidance...

@kostiantynperehuda

Copy link
Copy Markdown
Contributor Author

Thank you all

@kostiantynperehuda
kostiantynperehuda deleted the enable-cmake-addsubdirectory-pr branch November 7, 2025 15:45

This branch had an error being deployed

1 failed deployment
github-pages — 6943ae5f Deployed Nov 4, 2025 by gpeacock via deploy #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants