Fix healthcheck kwargs for container.create()#647
Open
inknos wants to merge 1 commit into
Open
Conversation
Honny1
reviewed
Jul 1, 2026
Honny1
left a comment
Honny1
left a comment
Member
There was a problem hiding this comment.
I have some comments. Moust of them are small improvments.
| f"Use Go-style durations like '30s', '1m', '500ms', '1h30m'." | ||
| ) | ||
| num_str, unit = match.groups() | ||
| total_ns += int(float(num_str) * DURATION_UNITS_NS[unit]) |
Member
There was a problem hiding this comment.
Well, using float feels odd. Why not int?
Member
There was a problem hiding this comment.
("1" -> 1.0000000001 could happen)
Contributor
Author
There was a problem hiding this comment.
I was thinking of "1.5s" being valid but we could do integers only. I see the validation is wrong anyway so doing ints seems ok. WDYT?
The health_* kwargs were being passed as snake_case in the JSON
payload, but /libpod/containers/create endpoint expects nested objects.
Assemble kwargs into proper structures:
- healthconfig: {Test, Interval, Timeout, Retries, StartPeriod}
- startupHealthConfig: {Test, Interval, Timeout, Retries, Successes}
- healthLogDestination, healthMaxLogCount, healthMaxLogSize (camelCase)
- health_on_failure string mapped to health_check_on_failure_action int
Also, it's possible to pass duration values as go-style strings
("30s", "1m", "500ms") and integers as nanoseconds.
Fixes: https://redhat.atlassian.net/browse/RHEL-140716
Signed-off-by: Nicola Sella <nsella@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The health_* kwargs were being passed as snake_case in the JSON payload, but /libpod/containers/create endpoint expects nested objects.
Assemble kwargs into proper structures:
Also, it's possible to pass duration values as go-style strings ("30s", "1m", "500ms") and integers as nanoseconds.
Fixes: https://redhat.atlassian.net/browse/RHEL-140716
keeping as draft since I want to sleep on the code before saying it's ready