This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 13, 2025. It is now read-only.
Support boolean values in resolveOptions func #174
Description
Allow for boolean values in resolveOption function: https://github.com/confio/ts-relayer/blob/main/src/binary/utils/options/resolve-option.ts
e.g.
const enableMetrics = resolveOption('enableMetrics', { required: true, boolean: true })(
flags.enableMetrics,
process.env.RELAYER_ENABLE_METRICS,
app?.enableMetrics,
false,
)Currently, it's only capable of resolving strings to string/integer.
Activity
bartmacbartek commentedon Apr 28, 2021
I wonder if this is not an overkill. If boolean flag is not passed, it gets a
falsevalue and we never need to throw. 🤷ethanfrey commentedon Apr 28, 2021
I guess you are right. Maybe just the non-required version?
bartmacbartek commentedon Apr 30, 2021
Yeah, I'll try to come up with something nice. Let's see...