fix: change permissions of read-only files before extracting in cache restore (#20241) - #20249
Open
ChickenisLegit wants to merge 1 commit into
Open
Conversation
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20241.
This PR fixes a
PermissionErrorthat occurs on Windows when runningconan cache restoreto extract an archive that contains read-only files (e.g., from an MSYS2 environment or a Git pack idx). Python'starfile.extractall()is unable to overwrite these existing read-only files if they already exist in the cache folder, which causes the restore process to fail withPermissionError: [Errno 13] Permission denied.Changes
conan/api/subapi/cache.pyto iterate through the members of the tar archive and explicitly set the read/write permissions (os.chmod(target_path, stat.S_IWRITE | stat.S_IREAD)) on existing files in the cache destination beforeextractall()attempts to overwrite them.