Repository navigation
Memoize Intervals::compactConstraint() results - #194
Merged
Merged
Conversation
Callers like Composer's PoolOptimizer compact the same few hundred constraints tens of thousands of times. The cache is keyed like the existing intervals cache and is freed by Intervals::clear().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer's `PoolOptimizer` calls `compactConstraint()` for every require and conflict link in the pool. On laravel/laravel that is about 58k calls for a few hundred distinct constraints (see composer/composer#13174). This caches the compacted result per constraint string, the same key `Intervals::get()` already uses. `clear()` frees it too.
Time spent in `PoolOptimizer::optimize()` on laravel/laravel, best of 15 in-process runs, median of 4 rounds:
The resulting lock files are identical. Doing it here also helps the other `compactConstraint()` callers, such as `PoolBuilder` and `ValidatingArrayLoader`.
Long-running processes that compact constraints without calling `Intervals::clear()` will now hold on to the cache, as the class docblock already warns.