Repository navigation
Distrust compromised eMudhra intermediates - #153
Merged
Merged
Conversation
paragonie-security
approved these changes
Oct 20, 2026
paragonie-security
left a comment
There was a problem hiding this comment.
https://emudhra.we-have-a-problem.com/ the details are public now.
…mediates in a presented chain
Member
Author
|
@paragonie-security happy to get another review here. It'll be combined with curl hooks in Composer that intercept requests and verify chains for bad CAs. See composer/composer#13146 also |
paragonie-security
approved these changes
Oct 20, 2026
Nice. We'll look at the other PR in the morning. |
- check every certificate in a multi-certificate PEM string - search the END marker after BEGIN - skip chain entries that are not PEM strings or X.509 certificates instead of warning - cap DER lengths at 3 bytes to avoid int overflow on 32-bit PHP - reject non-SEQUENCE structures and high-tag-number tags while walking the DER
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CaBundle::findDistrustedCertificate(array $chain)which looks for those intermediates (by SPKI, so the Sectigo cross-signs are covered too) in the chain presented by a server. Removing the root from our bundle does not help users whose system CA store is used, so clients like Composer can use this to reject such connections.