Conversation
ExtractVariables already walked :- and :+ operands, but skipped the
:? / ? error message, so ${U:?${B}} and ${U?$B} reported only U.
Substitute already expands that nested variable; collect it too.
Fixes compose-spec#934
Signed-off-by: Michał Furgała <83299832+00200200@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractVariables already walked nested interpolations in
:-/-and:+/+operands, but not in the:?/?error message.${U:?${B}}and${U?$B}therefore reported onlyU, while${U:-${B}}/${U:+${B}}reported both, even thoughSubstituteexpandsBwhen building the missing-variable error.The spec lists
${VARIABLE?$FOO}among nested interpolations (12-interpolation.md). Recurse into the required-error operand the same way as the default and presence operands.Fixes #934
Tests:
go test ./template/ -run TestExtractVariables(new casesnested-in-required-error-braced,nested-in-required-error-unbraced,nested-default-in-required-error);go test ./...green.