Skip to content

python-math #37: feat(math): mode collapse — Q15 watermark drop unconditional (item 4 parked) #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jucor wants to merge 1 commit into
base: spr/edge/13e86ed3
Choose a base branch
from
Draft

python-math #37: feat(math): mode collapse — Q15 watermark drop unconditional (item 4 parked) #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions delphi/polismath/conversation/conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,10 +1440,10 @@ def recompute(self) -> 'Conversation':
# has ONLY graph-node keys — :last-mod-timestamp is not one
# (conversation.clj:780-820), so every votes recompute DROPS the mod
# watermark; blobs carry lastModTimestamp only when the tick's last
# write was a mod-update. Improved mode keeps the persistent watermark
# (documented divergence). tests/test_mod_update_parity.py.
if resolve_engine_mode() == ENGINE_MODE_LEGACY:
result.last_mod_timestamp = None
# write was a mod-update. tests/test_mod_update_parity.py. (The
# former improved-mode persistent watermark is parked:
# POST_CUTOVER_IMPROVEMENTS.md item 4.)
result.last_mod_timestamp = None

# Compute PCA and projections
result._compute_pca(prev_pca=prev_pca)
Expand Down
13 changes: 0 additions & 13 deletions delphi/tests/test_mod_update_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ def legacy_mode(monkeypatch):
monkeypatch.setenv(ENGINE_MODE_ENV_VAR, 'clojure-legacy')


@pytest.fixture
def improved_mode(monkeypatch):
monkeypatch.setenv(ENGINE_MODE_ENV_VAR, 'improved')


def _conv(**sets):
conv = Conversation("mod-parity-probe", last_updated=1)
for attr, val in sets.items():
Expand Down Expand Up @@ -150,14 +145,6 @@ def test_votes_recompute_drops_watermark_in_legacy_mode(self, legacy_mode):
conv2 = conv.update_votes(dict(self.BATCH), recompute=True)
assert conv2.last_mod_timestamp is None

def test_watermark_persists_in_improved_mode(self, improved_mode):
# Documented divergence: improved mode keeps the sane persistent
# watermark instead of Clojure's graph-drop.
conv = Conversation("wm-keep", last_updated=1)
conv = conv.mod_update([_row(0, mod=-1, modified=777)])
conv2 = conv.update_votes(dict(self.BATCH), recompute=True)
assert conv2.last_mod_timestamp == 777


class TestGroupVotesTallyRawMatrix:
"""Clojure's group-votes aggregates votes-base, whose fnk reads
Expand Down
Loading