Skip to content

[storage] Remove live rewind and backward clear - #4907

Open
patrick-ogrady wants to merge 1 commit into
tact/recovery-remove-gluefrom
tact/recovery-remove-journal-removal
Open

patrick-ogrady wants to merge 1 commit into
tact/recovery-remove-gluefrom
tact/recovery-remove-journal-removal

Conversation

@patrick-ogrady

Copy link
Copy Markdown
Contributor

Remove live rewind from journals, persisted Merkle trees, and QMDB. Shortening happens during bounded initialization; live journal clears only move the boundary forward and reject backward targets before mutation.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8cecf11
Status: ✅  Deploy successful!
Preview URL: https://13fed907.monorepo-eu0.pages.dev
Branch Preview URL: https://tact-recovery-remove-journal.monorepo-eu0.pages.dev

View logs

@patrick-ogrady
patrick-ogrady added this pull request to stack #4899 September 21, 2026 22:25
@github-actions

Copy link
Copy Markdown

Benchmark results

Regressions: 0.

✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
Field Value
Package commonware-storage
Benchmark target qmdb_gungraun
Variant qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true
Filter *::bench_merkleize::any_unordered_fixed_mmr
Baseline suite commonware-storage
Gates EstimatedCycles should decrease; tolerance 10.00%; blob_reads should decrease; tolerance 10.00%
Cargo flags --features test-traits
Metric Baseline Current Delta Gate
Ir 13,414,729 13,427,157 +0.09% -
L1hits 17,212,922 17,226,102 +0.08% -
LLhits 105,671 106,827 +1.09% -
RamHits 4,479 7,140 +59.41% -
TotalRW 17,323,072 17,340,069 +0.10% -
EstimatedCycles 17,898,042 18,010,137 +0.63% EstimatedCycles should decrease; tolerance 10.00%
blob_reads 158 158 +0.00% blob_reads should decrease; tolerance 10.00%
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Field Value
Package commonware-storage
Benchmark target qmdb_gungraun
Variant qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true
Filter *::bench_merkleize::current_ordered_fixed_mmb_chunk_256
Baseline suite commonware-storage
Gates EstimatedCycles should decrease; tolerance 10.00%; blob_reads should decrease; tolerance 10.00%
Cargo flags --features test-traits
Metric Baseline Current Delta Gate
Ir 15,684,583 15,666,573 -0.11% -
L1hits 20,684,242 20,597,033 -0.42% -
LLhits 137,292 144,496 +5.25% -
RamHits 19,379 19,162 -1.12% -
TotalRW 20,840,913 20,760,691 -0.38% -
EstimatedCycles 22,048,967 21,990,183 -0.27% EstimatedCycles should decrease; tolerance 10.00%
blob_reads 235 235 +0.00% blob_reads should decrease; tolerance 10.00%

Baseline commit(s): bd0f7eb33af2

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp 8cecf11 Sep 21 2026, 10:24 PM

@patrick-ogrady
patrick-ogrady marked this pull request as ready for review September 22, 2026 03:36
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.21958% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.88%. Comparing base (4f82f17) to head (8cecf11).

Files with missing lines Patch % Lines
storage/src/qmdb/current/mod.rs 93.02% 2 Missing and 4 partials ⚠️
@@                      Coverage Diff                      @@
##           tact/recovery-remove-glue    #4907      +/-   ##
=============================================================
+ Coverage                      95.85%   95.88%   +0.03%     
=============================================================
  Files                            637      637              
  Lines                         306525   306377     -148     
  Branches                        7505     7496       -9     
=============================================================
- Hits                          293810   293762      -48     
+ Misses                         10346    10248      -98     
+ Partials                        2369     2367       -2     
Files with missing lines Coverage Δ
glue/src/stateful/db/current.rs 84.25% <100.00%> (+1.08%) ⬆️
storage/src/journal/authenticated.rs 95.88% <ø> (+0.20%) ⬆️
storage/src/journal/contiguous/blobs.rs 96.79% <ø> (+0.40%) ⬆️
storage/src/journal/contiguous/checkpoint.rs 100.00% <ø> (ø)
storage/src/journal/contiguous/fixed.rs 98.65% <100.00%> (-0.02%) ⬇️
storage/src/journal/contiguous/mod.rs 91.13% <ø> (+26.85%) ⬆️
storage/src/journal/contiguous/variable.rs 96.81% <100.00%> (-0.01%) ⬇️
storage/src/journal/durability.rs 96.96% <ø> (-0.33%) ⬇️
storage/src/merkle/mem.rs 98.27% <ø> (-0.01%) ⬇️
storage/src/merkle/mmr/full.rs 100.00% <100.00%> (ø)
... and 16 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f82f17...8cecf11. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants