[storage] Recover segmented journals before publication - #4902
patrick-ogrady wants to merge 1 commit into
Conversation
Deploying monorepo with
|
| Latest commit: |
9187393
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62a5fb64.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://tact-recovery-remove-segment.monorepo-eu0.pages.dev |
Benchmark resultsRegressions: ✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Baseline commit(s): |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9187393. Configure here.
| /// Open through `(section, logical byte end)` and remove later sections. | ||
| /// | ||
| /// An end inside an item rounds down. All retained data is validated before returning. Payload | ||
| /// reads stop at the bound, but every section name is validated, including names above it. |
There was a problem hiding this comment.
Public init docs leak edge cases
Low Severity
The public init_at_most docs describe rounding, payload-stop behavior, and validation of names above the bound. Those are edge-case and implementation details with a negative qualifier, rather than a description of the method's result.
Triggered by learned rule: Public API docs: no dependency names or "commonly used" sentences
Reviewed by Cursor Bugbot for commit 9187393. Configure here.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 9187393 | Sep 21 2026, 10:23 PM |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## tact/recovery-remove-authenticated #4902 +/- ##
======================================================================
+ Coverage 95.81% 95.83% +0.01%
======================================================================
Files 637 637
Lines 303469 304855 +1386
Branches 7428 7483 +55
======================================================================
+ Hits 290781 292160 +1379
- Misses 10314 10322 +8
+ Partials 2374 2373 -1
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
2 participants
Segmented journal initialization repairs and truncates through recovery owners before exposing append buffers. Oversized journals recover the index and value sections together, persisting the retained index boundary before discarding value data.