Skip to content

Remove prefix completely - #17

Open
drozzy wants to merge 5 commits into
commanded:masterfrom
drozzy:master
Open

Remove prefix completely#17
drozzy wants to merge 5 commits into
commanded:masterfrom
drozzy:master

Conversation

@drozzy

@drozzy drozzy commented Sep 8, 2018

Copy link
Copy Markdown

I got rid of the prefix, replacing it with the $streams stream. This works for loading aggregates pretty well, which is all I really need. Allows me to do projections in Greg's EventStore correctly (e.g. by using $ce-aggregatename):

screen shot 2018-09-08 at 7 08 26 pm

Did not test:

  • event handlers
  • process managers

@drozzy

drozzy commented Sep 9, 2018

Copy link
Copy Markdown
Author

This certainly breaks tests.. not sure how to fix them. E.g.:

5) test subscribe to all streams should receive events appended to any stream (Commanded.EventStore.Adapter.SubscriptionTest)
     deps/commanded/test/event_store_adapter/subscription_test.exs:105
     No message matching {:events, received_events} after 5000ms.
     The process mailbox is empty.

@drozzy

drozzy commented Sep 9, 2018

Copy link
Copy Markdown
Author

I also added a fix that set the extreme dep to ~> 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant