llvm cache - #90
Open
zeriyoshi wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The LLVM prefetch script can fail on a full cache miss due to adding the native dpkg architecture, and the new documentation overstates “Linux build jobs” coverage relative to the unchanged emulated workflow.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR introduces an LLVM apt package prefetch/cache flow intended to eliminate repeated downloads from apt.llvm.org during CI container builds by restoring a local llvm-debs/<codename>-<arch>/ apt repository and teaching the Dockerfile to consume it when present.
Changes:
- Add
LLVM_PACKAGESbuild arg and Dockerfile logic to install LLVM either from a localllvm-debs/...file-based apt repo or from apt.llvm.org. - Extend CI “Prepare” to prefetch LLVM
.debpackages per architecture, cache them, and pass cache keys into native Linux jobs for restore. - Document the LLVM install/caching behavior in both English and Japanese READMEs and ignore
llvm-debs/in git.
File summaries
| File | Description |
|---|---|
| README.md | Documents LLVM installation and CI cache behavior. |
| README_ja.md | Japanese documentation for LLVM installation and CI cache behavior. |
| Dockerfile | Adds LLVM package list arg and local-apt-repo install path via bind-mounted build context. |
| .gitignore | Ignores llvm-debs/ directory. |
| .github/workflows/ci.yaml | Wires LLVM cache key outputs from Prepare into native Linux workflow call. |
| .github/workflows/ci_prepare.yaml | Prefetches/caches LLVM .deb packages and outputs cache keys per arch. |
| .github/workflows/ci_native_linux.yaml | Restores the LLVM .deb cache for native Debian builds before container build. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.