Remove client uuid dependency - #168
Merged
Merged
Conversation
Replace the client's direct uuid package usage with a local browser UUID v4 helper for temporary chat/message IDs. This avoids the vulnerable direct client dependency without pulling modern uuid package syntax into the old Webpack 4 build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The direct client uuid package had an audit finding. Updating to uuid@11.1.1 is not compatible with the current Webpack 4 client build because the package ships modern syntax that this toolchain does not transpile from node_modules. Since the client only used UUIDs for local temporary message IDs, a local helper removes the vulnerable direct dependency without increasing build-chain risk.
The server remains on uuid@11.1.1.
Validation