Upgrade Socket.IO to v4 - #167
Merged
Merged
Conversation
Update the client and server Socket.IO packages together and replace socket.io-redis with the maintained Redis adapter using explicit ioredis pub/sub clients. Keep the full-stack Cypress lobby assertions stable when the local room list overflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Socket.IO 3 pulls older engine.io/ws runtime dependencies with known DoS advisories. Socket.IO 4 moves the runtime socket path to patched ws 8.21.0 while keeping the existing app protocol behavior covered by Cypress.
Validation
Sources checked: