fix(example): pass format and analysis checks - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI stopped at the Dart format gate after the example SDK floor moved to Dart 3.12. Apply the current formatter output and replace two unused
__callback parameters with_so the existing analyzer rules pass.Demo appearance and behavior are unchanged. No lint rules or CI checks are weakened.
Validation on Flutter 3.44.4 / Dart 3.12.2:
make checkpasses: 43 files formatted cleanly, package and example analysis report no issues, 135 package tests and 3 example tests pass.make publish-dry-runpasses with 0 warnings.