Let apps report non-notification scroll deltas - #30
Merged
codenameakshay merged 8 commits intoSep 19, 2026
Merged
Conversation
VisibilityAnimator already dropped pointer events and semantics when the bar was hidden, but hidden descendants could still take keyboard/TV focus. A TextField in the floating child stayed reachable after hide. Wrap the animated child in ExcludeFocus alongside the existing IgnorePointer/ExcludeSemantics gating in _wrapInteraction. Test file adapted from origin/t3code/creative-package-analysis-improvements:test/hidden_focus_test.dart (ExcludeFocus behavior only, not the rest of that branch).
Fresh resolution picked material_ui 1.3.0 and cupertino_ui 1.1.0, which use @awaitNotRequired, unavailable in the Dart shipped with Flutter 3.44.4. This broke CI package tests while local lockfiles still pinned working versions. Revert to open ranges after moving past Flutter 3.44.
…focus Exclude focus from hidden bar descendants
…radius Default BottomBarLayout radius to 28
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
BottomBarController.reportScroll({required double delta})for bodies that never emitScrollNotifications, such as an embedded WebView.It uses the same threshold, reverse, and
hideOnScrollrules as body scrolling, with an independent accumulator so it cannot mix with notification-tracked lists. Visibility only:scrollToStart/scrollToEndstill need a realScrollPosition.Stacked on PR 29 (plan 003). No WebView dependency or example demo.
Test plan
fvm flutter analyze— no issueshideOnScroll: false, unattached no-op, and isolated accumulatorsNotes
Remote CI is not claimed green until it finishes.