Default BottomBarLayout radius to 28 - #28
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing
layout:is treated as an explicit override, soBottomBarLayout.borderRadiusreplaced the built-in 28px decoration radius. The constructor default wasBorderRadius.zero, which made the documentedBottomBarLayout.adaptive(...)happy path draw a square bar.Both constructors now default to a 28px radius. Pass
BorderRadius.zerofor a square bar._effectiveBarBorderRadiusis unchanged. Example demos are unchanged.Test plan
fvm flutter analyze— no issuesfvm flutter test test/bottom_bar_layout_test.dart— 14 passed, including explicit-zero regressionsNotes
Independent of PR 27. Remote CI is not claimed green until it finishes.