Skip to content

fix: reduce timing-based user enumeration - #1382

Merged
datamweb merged 6 commits into
codeigniter4:developfrom
michalsn:fix/harden-auth-timing
Oct 13, 2026
Merged

datamweb merged 6 commits into
codeigniter4:developfrom
michalsn:fix/harden-auth-timing

Conversation

@michalsn

@michalsn michalsn commented Oct 2, 2026

Copy link
Copy Markdown
Member

Description
The OWASP Authentication Cheat Sheet recommends generic authentication errors and warns that early returns can reveal whether an account exists through response time. These changes address both discrepancies without claiming constant time for the entire request.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Something isn't working label Oct 2, 2026
Comment thread src/Authentication/Authenticators/HmacSha256.php Outdated
@michalsn
michalsn force-pushed the fix/harden-auth-timing branch from d13af64 to 0519679 Compare October 12, 2026 12:12

@datamweb datamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @michalsn.

@datamweb
datamweb merged commit 998dc81 into codeigniter4:develop Oct 13, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants