Skip to content

Fix crud - #577

Merged
SanjulaGanepola merged 2 commits into
mainfrom
fixCrud
Sep 29, 2026
Merged

SanjulaGanepola merged 2 commits into
mainfrom
fixCrud

Conversation

@buzzia2001

@buzzia2001 buzzia2001 commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

Changes

This PR fixed CRUD statement as requested by @forstie in #566.

How to test this PR

Check if the syntax generate by vscode is the same like ACS' one for this table:

CREATE TABLE "annoying"."annoyingly123" FOR SYSTEM NAME "anno0001" (
PARK_NAME VARCHAR(50) CCSID 37 DEFAULT NULL ,
GEOMETRY QSYS2.ST_POLYGON DEFAULT NULL ,
"'thetime""" FOR COLUMN QTHET00001 TIMESTAMP(12) DEFAULT NULL )

RCDFMT "annoy1" ;

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@buzzia2001
buzzia2001 requested review from a team, forstie and ryan-moeller21 September 20, 2026 19:46
@buzzia2001 buzzia2001 self-assigned this Sep 20, 2026
@buzzia2001 buzzia2001 added the bug Something isn't working label Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

👋 A new build is available for this PR based on 800e3cf.

@SanjulaGanepola

Copy link
Copy Markdown
Member

@buzzia2001 Changes look good. One thing I noticed though when testing the example that Scott shared, I see that ACS uses IS NOT DISTINCT FROM for a nullable column instead of = for an update and delete. Can we do the same? Not sure if there is more specifics rules for this?

@buzzia2001

Copy link
Copy Markdown
Member Author

@SanjulaGanepola to you

@SanjulaGanepola SanjulaGanepola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@SanjulaGanepola
SanjulaGanepola merged commit 0973e0f into main Sep 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants