Skip to content

Profile card - #84

Merged
axdanbol merged 4 commits into
mainfrom
profile-card
Jul 20, 2026
Merged

Profile card#84
axdanbol merged 4 commits into
mainfrom
profile-card

Conversation

@edlu77

@edlu77 edlu77 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

@edlu77
edlu77 requested review from LibbyUX and axdanbol July 20, 2026 18:54
@edlu77 edlu77 self-assigned this Jul 20, 2026
@nx-cloud

nx-cloud Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit fed9270

Command Status Duration Result
nx affected -t lint test build build-compodoc b... ✅ Succeeded 2m 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- commitlint --from 1dd6292de9... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-20 19:01:12 UTC

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The fix from Nx Cloud was applied

We ran nx format to fix the format:check failure caused by the profile card spec file using tab indentation instead of the project's standard 2-space indentation. Our change brings libs/labs/profile-card/src/lib/profile-card.spec.ts into compliance with the Prettier configuration, which will allow the nx format:check task to pass.

Tip

We verified this fix by re-running nx-cloud record -- nx format:check.

Suggested Fix changes
diff --git a/libs/labs/profile-card/src/lib/profile-card.spec.ts b/libs/labs/profile-card/src/lib/profile-card.spec.ts
index 751fa58..d54b05d 100644
--- a/libs/labs/profile-card/src/lib/profile-card.spec.ts
+++ b/libs/labs/profile-card/src/lib/profile-card.spec.ts
@@ -2,17 +2,14 @@ import { ComponentInput, render, screen } from '@testing-library/angular';
 import { ProfileCard } from './profile-card';
 
 describe('ProfileCard', () => {
-	type SetupOptions = {
-		inputs?: ComponentInput<ProfileCard>;
-		content?: string;
-	};
+  type SetupOptions = {
+    inputs?: ComponentInput<ProfileCard>;
+    content?: string;
+  };
 
-	function setup({
-		inputs = {},
-		content = '<a href="/profile">View profile</a>',
-	}: SetupOptions = {}) {
-		return render(
-			`<ang-profile-card
+  function setup({ inputs = {}, content = '<a href="/profile">View profile</a>' }: SetupOptions = {}) {
+    return render(
+      `<ang-profile-card
 				[pictureUrl]="pictureUrl"
 				[name]="name"
 				[description]="description"
@@ -20,49 +17,49 @@ describe('ProfileCard', () => {
 			>
 				${content}
 			</ang-profile-card>`,
-			{
-				imports: [ProfileCard],
-				componentProperties: {
-					pictureUrl: '/assets/profile.png',
-					name: 'Ada Lovelace',
-					description: 'Mathematician',
-					centerContent: false,
-					...inputs,
-				},
-			},
-		);
-	}
+      {
+        imports: [ProfileCard],
+        componentProperties: {
+          pictureUrl: '/assets/profile.png',
+          name: 'Ada Lovelace',
+          description: 'Mathematician',
+          centerContent: false,
+          ...inputs,
+        },
+      },
+    );
+  }
 
-	it('renders the name and description text', async () => {
-		await setup();
+  it('renders the name and description text', async () => {
+    await setup();
 
-		expect(screen.getByText('Ada Lovelace')).toBeInTheDocument();
-		expect(screen.getByText('Mathematician')).toBeInTheDocument();
-	});
+    expect(screen.getByText('Ada Lovelace')).toBeInTheDocument();
+    expect(screen.getByText('Mathematician')).toBeInTheDocument();
+  });
 
-	it('renders the profile picture with src and accessible alt text', async () => {
-		await setup();
+  it('renders the profile picture with src and accessible alt text', async () => {
+    await setup();
 
-		const image = screen.getByRole('img', { name: 'Profile picture of Ada Lovelace' });
+    const image = screen.getByRole('img', { name: 'Profile picture of Ada Lovelace' });
 
-		expect(image).toHaveAttribute('src', '/assets/profile.png');
-	});
+    expect(image).toHaveAttribute('src', '/assets/profile.png');
+  });
 
-	it('renders projected action content', async () => {
-		await setup({ content: '<button type="button">Connect</button>' });
+  it('renders projected action content', async () => {
+    await setup({ content: '<button type="button">Connect</button>' });
 
-		expect(screen.getByRole('button', { name: 'Connect' })).toBeInTheDocument();
-	});
+    expect(screen.getByRole('button', { name: 'Connect' })).toBeInTheDocument();
+  });
 
-	it('applies the center-content host class when centerContent is true', async () => {
-		const { container } = await setup({ inputs: { centerContent: true } });
+  it('applies the center-content host class when centerContent is true', async () => {
+    const { container } = await setup({ inputs: { centerContent: true } });
 
-		expect(container.querySelector('ang-profile-card')).toHaveClass('ang-profile-card-center-content');
-	});
+    expect(container.querySelector('ang-profile-card')).toHaveClass('ang-profile-card-center-content');
+  });
 
-	it('does not apply the center-content host class by default', async () => {
-		const { container } = await setup();
+  it('does not apply the center-content host class by default', async () => {
+    const { container } = await setup();
 
-		expect(container.querySelector('ang-profile-card')).not.toHaveClass('ang-profile-card-center-content');
-	});
+    expect(container.querySelector('ang-profile-card')).not.toHaveClass('ang-profile-card-center-content');
+  });
 });

Revert fix via Nx Cloud  

View interactive diff ↗

➡️ This fix was applied by Edward Lu

🎓 Learn more about Self-Healing CI on nx.dev

Co-authored-by: edlu77 <edlu77@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

🚀 Preview Deploy Report

✅ Successfully deployed preview here

@axdanbol
axdanbol merged commit 920abee into main Jul 20, 2026
1 check passed
@axdanbol
axdanbol deleted the profile-card branch July 20, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants