[jcode] Add H3 camera movement preset chips - #10
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by the cumulative, adversarially reviewed and merged #11. |
Draft PR opened by jcode Cloud Agent for run
77ee5c87404b0984852c343d6ad736af.Triggered by a jtype kanban card.
Task
Add H3 camera movement preset chips
Context
MiniMax's official H3 guide recommends camera-motion cues such as pan, zoom,
tracking, and static shots. Creators should not have to remember or repeatedly
type the supported syntax. This request was produced from external product/API
research and intentionally enters Backlog before implementation approval.
Sources:
Requested outcome
Add accessible camera movement preset chips to the generation composer. A user
can insert a preset at the current prompt cursor without losing surrounding text.
At minimum include: Pan left, Pan right, Push in, Pull out, Tracking shot, and
Static shot. Keep the preset data in a small shared/pure module so labels and
inserted tokens are testable and are not duplicated across the UI.
Acceptance criteria
accessible names.
preserves surrounding prompt text.
request policy before submission.
a selection.
Delivery
Create a ready-for-review PR. Do not call the paid MiniMax API. Use mock mode for
all automated validation.
Adversarial review follow-up
PR #9 is not merge-ready yet. Before editing, fetch
origin/jcode/run-34055d9band reset the Cloud working branch to exact commit4e62adaa0ed6c57b9c6ea38c2df029e4eb41a20c. Preserve its intended feature andfix these independently verified gaps without redesigning unrelated code:
user who clicks a chip before filling variables must never freeze the prompt
to only the camera token. Add a component regression for this sequence.
submit stale prompt text with different recorded values. Track the values
snapshot used by the override, disable generation on a mismatch, show a clear
recovery message, and allow Reset to rendered to restore a consistent prompt.
Test fill → insert → change variable → blocked → reset → consistent submit.
valuesevenwhen a nonblank prompt override is supplied, so unresolved variables and
template syntax errors still fail before any job/provider call. The validated
override remains the final rendered prompt after this validation succeeds.
parameters.promptretainsthe camera-cue override on retry instead of falling back to version rendering.
Careartypo. If practical, expose preset descriptions througharia-describedbyrather than relying only ontitle.Run frozen install if needed, lint, typecheck, all tests, and production build.
Baseline is 289 tests. Re-read every edited file after the gates. Do not call
paid MiniMax or add secrets. Cloud owns delivery and must create a Ready PR.
Branch
jcode/run-77ee5c87@2cb5325afb3647bbff0fc5641ac1fe35d1eed7c3.Not auto-merged and CI is not auto-triggered — review and iterate.