Introspection for SoABlocks - #51670
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51670/50542
|
|
A new Pull Request was created by @Electricks94 for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
please test |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
The GPU workflows failed with Is something wrong with the matrix? |
My guess is that after #51633 this Needs an update |
|
Ah. So maybe
was not such a good idea? |
|
@cms-sw/all-l2 can we please stop breaking the PR tests with updates to the geometry ? |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: RelVals-AMD_MI300X amd_mi300xUnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed RelVals-AMD_MI300X
Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
The duplicate/invalid dictionary errors are caused by #51577 . |
Just for my understanding, are these real issues which need to be fixed, or are those pseudo-issues that only happen because #51577 was included on top of the lastest IB instead of being part of an IB directly? |
Right, I'd expect the "duplicate plugins" warning to disappear after the first full build IB (patch build IBs won't be enough). |
|
@Electricks94 this branch now has developed conflicts to be resolved. |
|
type ngt |
resolved |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51670/50729
|
| #include "DataFormats/SoATemplate/interface/SoALayout.h" | ||
| #include "DataFormats/SoATemplate/interface/SoABlocks.h" |
There was a problem hiding this comment.
| #include "DataFormats/SoATemplate/interface/SoALayout.h" | |
| #include "DataFormats/SoATemplate/interface/SoABlocks.h" | |
| #include "DataFormats/SoATemplate/interface/SoABlocks.h" | |
| #include "DataFormats/SoATemplate/interface/SoALayout.h" |
| @@ -1 +1 @@ | |||
| #include <iostream> | |||
There was a problem hiding this comment.
| #include <array> | |
| #include <iostream> |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51670/50730
|
|
enable gpu |
|
please test |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 1 errors in the following unit tests: ---> test SoAStreamInternal_t had ERRORS Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51670/50738
|
|
please test |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
Max Memory Comparisons exceeding threshold NVIDIA_T4@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
+1 |
PR description:
This PR extends the SoABlocks Layout for the introspection functionality. Normal SoALayouts can be printed using the stream insertion operator. In this way the total size in bytes as well as the byte size for each column and the used padding can be viewed. With this PR the stream insertion operator can also be used for SoABlocks which will output the size of each layout that is contained in the blocks and then the total size of the SoABlocks Layout.
PR validation:
This PR is validated by extending the
SoAStreamInternal_ttest case. In this test case an expected output stream for a specific layout is hardcoded and the output of the stream insertion operator is then checkedFYI @felicepantaleo