Fix PyTorch ROCm library linking - #10826
Closed
EmanueleCoradin wants to merge 1 commit into
Closed
Conversation
Contributor
|
cms-bot internal usage |
Author
|
type ngt |
Contributor
|
@EmanueleCoradin can you drop |
fwyzard
reviewed
Sep 3, 2026
EmanueleCoradin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds two additional linker settings:
FORCE_LINKensures that the ROCm backend library is kept in the final dependency chain even when no symbol from it is referenced directly.-L$TOOL_BASE/libgives priority to the libraries shipped with the ROCm PyTorch package when linking a ROCm target. This ensures thatlibtorch_hip,libtorch_cpu,libc10, etc. all come from the same ROCm PyTorch build, instead of accidentally mixing ROCm-specific libraries with the generic PyTorch libraries.