[rocm-llvm] make sure to deploy clang.cfg and host-triple.cfg - #10804
Open
smuzaffar wants to merge 1 commit into
Open
[rocm-llvm] make sure to deploy clang.cfg and host-triple.cfg#10804smuzaffar wants to merge 1 commit into
smuzaffar wants to merge 1 commit into
Conversation
Contributor
Author
|
please test |
Contributor
|
A new Pull Request was created by @smuzaffar for branch IB/CMSSW_20_1_X/master. @akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks. |
Contributor
|
cms-bot internal usage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @akritkbehera , rocm-comgr failed to build on cmsdev machines (for
el8_amd64_*) asclangfrom rocm-llvm was picking up gcc from system and complain about missing-lgcc -lgcc_s. Things worked in our container (el8) as we have extra gcc packages installed there andclangwas able to findgcc and gcc_sfrom system. The proper fix is that we should haveclang.cfgdeployed with the correct gcc-toolchain. This change fixes this issue