Skip to content

[17_0_X] Update hls4mlEmulatorExtras to v1.1.7 (backport) - #10777

Merged
cmsbuild merged 1 commit into
cms-sw:IB/CMSSW_17_0_X/masterfrom
quinnanm:fix-hls4mlEmulatorExtras-17_0
Aug 10, 2026
Merged

[17_0_X] Update hls4mlEmulatorExtras to v1.1.7 (backport)#10777
cmsbuild merged 1 commit into
cms-sw:IB/CMSSW_17_0_X/masterfrom
quinnanm:fix-hls4mlEmulatorExtras-17_0

Conversation

@quinnanm

Copy link
Copy Markdown
Contributor

update hls4mlEmulatorExtras to v1.1.7
adds fix for early model destruction cms-hls4ml/hls4mlEmulatorExtras#7 as included in cms-hls4ml/hls4mlEmulatorExtras#8 (avoid early dlclose call). Spotted in cms-sw/cmssw#51633

Also adds fix to shared pointer type mismatch found #10770 (comment) and other bugs as mentioned below. Verified compilation.

Backport of #10770

@quinnanm

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @quinnanm for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4a09f/55220/summary.html
COMMIT: 4f7453b
CMSSW: CMSSW_17_0_X_2026-08-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10777/55220/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4337615
  • DQMHistoTests: Total failures: 163
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4337432
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 232 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: found differences in 1 / 52 workflows

@smuzaffar

Copy link
Copy Markdown
Contributor

+externals

@cms-sw/orp-l2 , feel free to include this in next 17.0.X IBs/release. This is backport of #10770

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown

+1

@cmsbuild
cmsbuild merged commit 1ce33b7 into cms-sw:IB/CMSSW_17_0_X/master Aug 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants