Skip to content

fix: use identity mapper as default for AzureModelMapperFunc #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxcxjxhx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use identity mapper as default for AzureModelMapperFunc #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion libs/acl/openai/chat_model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ type Config struct {

// AzureModelMapperFunc is used to map the model name to the deployment name for Azure OpenAI Service.
// This is useful when the model name is different from the deployment name.
// Optional for Azure, remove [,:] from the model name by default.
// Optional for Azure. Defaults to an identity function (no transformation).
// The upstream SDK historically stripped [.:] from names; set this field to
// restore that behaviour if your deployment names rely on it.
AzureModelMapperFunc func(model string) string

// BaseURL is the Azure OpenAI endpoint URL
Expand Down Expand Up @@ -238,6 +240,12 @@ func NewClient(ctx context.Context, config *Config) (*Client, error) {
}
if config.AzureModelMapperFunc != nil {
clientConf.AzureModelMapperFunc = config.AzureModelMapperFunc
} else {
// Use identity mapper by default: deployment names are user-provided
// identifiers that should be passed through unchanged. The upstream
// SDK strips dots from model names by default (legacy Azure convention),
// which breaks modern Foundry deployments whose names contain dots.
clientConf.AzureModelMapperFunc = func(model string) string { return model }
}
} else {
clientConf = openai.DefaultConfig(config.APIKey)
Expand Down
Loading