feat(callbacks/langfuse): optional OpenAI-shaped tools on generation … - #943
Open
SunflowersFacingNight wants to merge 3 commits into
Open
Conversation
…Input
Add Config.ReportTools (default false). When enabled and tools are bound,
serialize generation Input as OpenAI chat.request JSON:
{messages, tools[{type:function,function:{...}}], tool_choice}.
Playground extractTools reads input.tools; skip InMessages so the acl
consumer does not overwrite Input. modelParameters stay *model.Config.
|
|
Only set OpenAI-shaped Input when at least one non-nil tool converts; all-nil or empty tools keep InMessages for the ACL media path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.ReportTools(defaultfalse).{messages, tools[{type:function,function:{...}}], tool_choice}for Langfuse PlaygroundextractTools.InMessageson that path so the acl consumer does not overwrite Input with messages-only JSON.modelParametersas*model.Config(sampling only).Test plan
ReportTools: true, generation Input containstools/tool_choiceandInMessagesis emptyReportTools: falseis unchanged (existing generation tests cover the InMessages path)ReportToolsenabled, Langfuse generation Input is OpenAI chat.request–shaped and includes bound tool definitionsReportToolsdisabled, reporting matches previous behavior