Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
<type>(scope): <description>.More detailed description
Importing the OpenAI model component in a standalone Go 1.26 application selects Sonic v1.14.1 and fails to compile with
undefined: GoMapIterator. Raise the component's Sonic dependency to v1.15.0, which adds Go 1.26 support, and update its loader dependency to v0.5.0.Also raise Mockey to v1.4.5, which supports Go 1.26, so the component's existing tests can run on that toolchain instead of failing to link references to
runtime.duffcopyandruntime.duffzero. Changes are limited to this component'sgo.modandgo.sum.The current ACL source already requires Sonic v1.15.0, but this component depends on the released ACL v0.1.17. Testing as a standalone consumer with
GOWORK=offverifies the dependency selection users actually get.Validation
In
components/model/openai, withGOWORK=off, on both Go 1.25.6 and Go 1.26.7 (Linux/amd64):go test -race -gcflags='all=-N -l' -count=1 ./...go vet ./...Additional validation:
Generate,Stream, and message concatenation pass on both Go versions.CGO_ENABLED=0). The original dependency set fails with the reported error on both Linux and Windows build targets. No native Windows execution was performed.golangci-lintv2.5.0 reports no issues using a temporary migration of the repository's v1 configuration, under Go 1.25.6.git diff --checkpasses.Validation covers the OpenAI component and its standalone consumer, not all modules in eino-ext. No tests were disabled or rewritten.
Which issue(s) this PR fixes
Fixes #997.