Repository navigation
Conversation
…hreshold inoperative Bug: Dynamic ScoreThreshold from Option is ignored. Root cause: The code only reads r.scoreThreshold (set at creation time) and never reads co.ScoreThreshold (passed per-request via Option). When r.scoreThreshold is nil (no default configured), ScoreThreshold is never set on the request. When r.scoreThreshold is set, it silently overrides any dynamic value from Option. Fix: Apply priority co.ScoreThreshold > r.scoreThreshold > nil, with single float64->float32 conversion at assignment.
fix(components/retriever/qdrant): runnable WithRetrieverOption scoreT…
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(components/retriever/qdrant): runnable WithRetrieverOption scoreThreshold inoperative
Bug: Dynamic ScoreThreshold from Option is ignored. Root cause: The code only reads r.scoreThreshold (set at creation time) and never reads co.ScoreThreshold (passed per-request via Option). When r.scoreThreshold is nil (no default configured), ScoreThreshold is never set on the request. When r.scoreThreshold is set, it silently overrides any dynamic value from Option.
Fix: Apply priority co.ScoreThreshold > r.scoreThreshold > nil, with single float64->float32 conversion at assignment.
What type of PR is this?
fix: runnable WithRetrieverOption scoreThreshold noperative
Which issue(s) this PR fixes:
Fixes (#1017)