Repository navigation
feat: Enable additional CloudFront real-time metrics - #372
Veronika Gnilitska (gberenice) merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds optional CloudFront real-time metrics monitoring to a Terraform module. A new boolean input variable ChangesCloudFront real-time metrics monitoring
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/terratest |
989fa0e
into
cloudposse:main
|
These changes were released in v2.1.1. |
what
Add
additional_metrics_enabledvariable (default:falsefor backwards compatibility) that provisions anaws_cloudfront_monitoring_subscriptionresource when enabled.why
Not all CloudFront metrics are enabled by default. Some (4xx/5xx error rates by HTTP status code, origin latency, and cache hit rate) are hidden behind a monitoring subscription. This adds a convenient switch to enable them when needed.
The
realtime_metrics_subscription_statusvalue could have been derived fromvar.additional_metrics_enabled, but that would introduce an unexpected resource change across all existing deployments.references
A complementary PR to cloudposse/terraform-aws-cloudfront-cdn#162