Skip to content

clean up local testing paths in miniflare v5#14599

Draft
emily-shen wants to merge 2 commits into
miniflare-v5from
emily/update-paths
Draft

clean up local testing paths in miniflare v5#14599
emily-shen wants to merge 2 commits into
miniflare-v5from
emily/update-paths

Conversation

@emily-shen

Copy link
Copy Markdown
Contributor

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2ffa89c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
miniflare Major
@cloudflare/deploy-helpers Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

This PR removes Miniflare's built-in live reload mechanism (the /cdn-cgi/mf/reload WebSocket endpoint, the liveReload option, and the HTML <script> injection), and drops the now-unused liveReload pass-through in Wrangler's Miniflare code paths. The Wrangler-side --live-reload flag still works via the ProxyWorker, which is correct.

One actionable issue:

  1. Stale public API docspackages/miniflare/README.md (lines 769-773) still documents the liveReload?: boolean option that this PR removes. Since this is a major breaking change to Miniflare's public API, the README should be updated to drop this entry so users aren't pointed at a removed option. This file isn't part of the diff, so I can't attach an inline suggestion, but the block to delete is:
- `liveReload?: boolean`

  If `true`, Miniflare will inject a script into HTML responses that
  automatically reloads the page in-browser whenever the Miniflare instance's
  options are updated.

Minor (non-blocking) note: loopbackPort remains in GlobalServicesOptions and is still passed by callers, but is no longer read inside getGlobalServices now that the live reload script (its only consumer) is gone. Safe to leave, but could be cleaned up if it's not needed elsewhere.

@ask-bonk

ask-bonk Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review posted successfully to PR #14599.

Summary of my review: The PR cleanly removes Miniflare's built-in live reload mechanism. I verified:

  • The Wrangler --live-reload flag still works (via the separate ProxyWorker mechanism).
  • The remaining liveReload references in Wrangler (LocalRuntimeController, MultiworkerRuntimeController, ProxyController config) are for the ProxyWorker, not the removed Miniflare option — correct to keep.
  • The schema isn't .strict(), so any stray liveReload prop is stripped, not an error — no backward-compat break in validation.

I flagged one actionable issue: the miniflare README still documents the removed liveReload?: boolean public option (a major breaking change), and a minor non-blocking note about the now-unused loopbackPort field.

github run

@pkg-pr-new

pkg-pr-new Bot commented Jul 8, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14599

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14599

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14599

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14599

miniflare

npm i https://pkg.pr.new/miniflare@14599

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14599

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14599

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14599

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14599

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14599

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14599

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14599

wrangler

npm i https://pkg.pr.new/wrangler@14599

commit: 323bb51

@emily-shen emily-shen changed the base branch from main to miniflare-v5 July 8, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants